-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tantan module #6256
base: master
Are you sure you want to change the base?
Added tantan module #6256
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked nf-test
and prettier
locally. The tests pass and pettier run --all-files
modifies only files outside the modules/nf-core/tantan
path. My comments are about the input and output channels of the module.
- fasta: | ||
type: file | ||
description: FASTA file containing a nucleotide sequence. | ||
pattern: "*.{fa,fa.gz,fasta,fasta.gz,fna,fna.gz}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tantan also accepts FASTQ input; maybe you can rename the input channel to fastx
and expand the pattern to accept fq
, fq.gz
, fastq
and fastq.gz
?
description: | | ||
Groovy Map containing sample information | ||
e.g. `[ id:'sample1', single_end:false ]` | ||
- masked_fasta: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you allow FASTQ input then either you need one output channel that will contain FASTA or FASTQ, or you need one separate channel for each format.
description: FASTA file containing a nucleotide sequence. | ||
pattern: "*.{fa,fa.gz,fasta,fasta.gz,fna,fna.gz}" | ||
|
||
output: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to describe the repeat_probs
, repeat_counts
, bed
, and tandem_repeats
channels too.
PR checklist
Closes #XXX
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda